feat: new WriteOption config for capturing backpressure data #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #848 +/- ##
============================================
+ Coverage 88.51% 88.81% +0.29%
- Complexity 787 791 +4
============================================
Files 174 174
Lines 7207 7248 +41
Branches 405 413 +8
============================================
+ Hits 6379 6437 +58
+ Misses 697 680 -17
Partials 131 131 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fredjoonpark
force-pushed
the
capture-backpressure
branch
2 times, most recently
from
3cd2b34 to
84e6774
Compare
fredjoonpark
force-pushed
the
capture-backpressure
branch
from
84e6774 to
e92640e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #846
Proposed Changes
Introduces an (optional) new WriteOption config,
captureBackpressureData, which captures dropped data points on backpressure events.Additionally adds another config called
concatMapPrefetch- previously, the client was callingconcatMapMaybewith an undocumented prefetch value (source). This matters because prefetched batches are removed from the buffer and needs to be accounted for during testing. Made this configurable with the default set as what it's been using.Checklist
mvn testcompletes successfully